MSK - Glue Schema registry demo using Python #2778
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* python implementation * working version * working code * simplified code * final changes
leandrodamascena
suggested changes
Jun 30, 2025
There was a problem hiding this comment.
Thats a super amazing work @vaibhavjainv! I just left some small comments.
| logger.info("=== MSK AVRO Consumer Lambda started ===") | ||
|
|
||
| try: | ||
| record_count = 0 |
| try: | ||
| record_count = 0 | ||
| for record in event.records: | ||
| record_count += 1 |
| # Add your business logic here | ||
| # For example: save to database, send notifications, etc. | ||
|
|
||
| logger.info(f"Successfully processed {record_count} records") |
There was a problem hiding this comment.
Suggested change
| logger.info(f"Successfully processed {record_count} records") | |
| logger.info(f"Successfully processed {len(list(event.records))} records") |
Comment on lines
2
to
6
| aws-lambda-powertools>=3.15.0 | ||
|
|
||
| # Avro serialization | ||
| fastavro>=1.8.0 | ||
| avro>=1.11.0 |
There was a problem hiding this comment.
Suggested change
| aws-lambda-powertools>=3.15.0 | |
| # Avro serialization | |
| fastavro>=1.8.0 | |
| avro>=1.11.0 | |
| aws-lambda-powertools[kafka-consumer-avro]>=3.15.0 |
Comment on lines
267
to
270
| logger.exception("Error in lambda_handler", extra={ | ||
| "error": str(e), | ||
| "error_type": type(e).__name__ | ||
| }) |
There was a problem hiding this comment.
logger.exception already propagate error type and name.
Suggested change
| logger.exception("Error in lambda_handler", extra={ | |
| "error": str(e), | |
| "error_type": type(e).__name__ | |
| }) | |
| logger.exception("Error in lambda_handler") |
| response = kafka_client.get_bootstrap_brokers(ClusterArn=cluster_arn) | ||
| return response['BootstrapBrokerStringSaslIam'] | ||
| except Exception as e: | ||
| logger.exception("Failed to get bootstrap brokers", extra={"cluster_arn": cluster_arn}) |
There was a problem hiding this comment.
Suggested change
| logger.exception("Failed to get bootstrap brokers", extra={"cluster_arn": cluster_arn}) | |
| logger.exception("Failed to get bootstrap brokers", cluster_arn=cluster_arn) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Python implementation for MSK - Glue Schema registry demo.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.