Skip to content

apigw-lambda-dynamodb-terraform: Update runtime to python3.12 #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −5
Open

apigw-lambda-dynamodb-terraform: Update runtime to python3.12 #2799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18e3324
apigw-lambda-dynamodb-terraform: Update runtime to python3.12
kakakakakku Jul 19, 2025
14a9159
apigw-lambda-dynamodb-terraform: Add .gitignore
kakakakakku Jul 19, 2025
ce423dc
apigw-lambda-dynamodb-terraform: Use aws_s3_bucket_public_access_bloc…
kakakakakku Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apigw-lambda-dynamodb-terraform/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
src.zip
14 changes: 9 additions & 5 deletions apigw-lambda-dynamodb-terraform/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 4.0.0"
version = "~> 5.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Older version does not support Python 3.12 runtime. So I updated the version to v5.

}
random = {
source = "hashicorp/random"
Expand Down Expand Up @@ -56,9 +56,13 @@ resource "aws_s3_bucket" "lambda_bucket" {
force_destroy = true
}

resource "aws_s3_bucket_acl" "private_bucket" {
resource "aws_s3_bucket_public_access_block" "private_bucket" {
bucket = aws_s3_bucket.lambda_bucket.id
acl = "private"

block_public_acls = true
block_public_policy = true
ignore_public_acls = true
restrict_public_buckets = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: The following error occurred when applying.

╷
│ Error: creating S3 Bucket (apigw-lambda-ddb20250719083122545300000001) ACL: operation error S3: PutBucketAcl, https response error StatusCode: 400, RequestID: RTCDVY9T5Y9NE0MW, HostID: vfd4QSf6vdz0D13xfdcM0lQDDIncDGdaEDF5Zsu1HhwOzmpYDt5r3C/0j1MKxlXp2QAnWBExjFw=, api error AccessControlListNotSupported: The bucket does not allow ACLs
│ 
│   with aws_s3_bucket_acl.private_bucket,
│   on main.tf line 58, in resource "aws_s3_bucket_acl" "private_bucket":
│   58: resource "aws_s3_bucket_acl" "private_bucket" {
│ 
╵

This issue is related to the changes described in the following blog post. To fix this, I enabled Block Public Access for the S3 bucket😀

Disabling ACLs is an S3 security best practice, and in April of 2023, we disabled ACLs by default for all new buckets.
https://aws.amazon.com/jp/blogs/storage/disabling-acls-for-existing-amazon-s3-workloads-with-information-in-s3-server-access-logs-and-aws-cloudtrail/

}

data "archive_file" "lambda_zip" {
Expand All @@ -85,7 +89,7 @@ resource "aws_lambda_function" "apigw_lambda_ddb" {
s3_bucket = aws_s3_bucket.lambda_bucket.id
s3_key = aws_s3_object.this.key

runtime = "python3.8"
runtime = "python3.12"
handler = "app.lambda_handler"

source_code_hash = data.archive_file.lambda_zip.output_base64sha256
Expand Down Expand Up @@ -222,4 +226,4 @@ resource "aws_lambda_permission" "api_gw" {
principal = "apigateway.amazonaws.com"

source_arn = "${aws_apigatewayv2_api.http_lambda.execution_arn}/*/*"
}
}