Skip to content

feat: add VPC info messages to dev and invoke commands [3/3]#426

Merged
tejaskash merged 2 commits intomainfrom
feat/vpc-3-ux-messages
Feb 24, 2026
Merged

feat: add VPC info messages to dev and invoke commands [3/3]#426
tejaskash merged 2 commits intomainfrom
feat/vpc-3-ux-messages

Conversation

@tejaskash
Copy link
Copy Markdown
Contributor

Summary

Add informational messages when working with VPC-mode agents in dev and invoke commands.

Depends on #424 (schema foundation). This PR includes those schema commits as a base.

Changes

  • dev command: When an agent has networkMode: 'VPC', display a note that VPC networking does not apply to local development
  • invoke command: When invoking a VPC-mode agent, display guidance about required VPC Endpoints (S3, ECR, Bedrock) and note that non-Bedrock model providers require public internet access from within the VPC

Files changed (2)

File Change
src/cli/commands/dev/command.tsx VPC info message in logs path and before alt screen
src/cli/commands/invoke/action.ts VPC Endpoint guidance warning

Stack

This PR and PR 2/3 are independent — reviewable and mergeable in any order after PR 1/3.

Test plan

  • TypeScript compiles clean
  • Lint and prettier pass
  • agentcore dev --logs on a VPC-mode agent shows info note
  • agentcore invoke on a VPC-mode agent shows VPC Endpoint guidance

Fix NetworkModeSchema enum from PUBLIC|PRIVATE to PUBLIC|VPC to match
the AWS API. Add NetworkConfigSchema for subnet and security group
validation, and networkConfig field to AgentEnvSpec with cross-field
validation requiring networkConfig when networkMode is VPC.

Changes:
- Fix NetworkModeSchema enum: PRIVATE → VPC
- Add NetworkConfigSchema (subnet/SG ID regex, min/max array bounds)
- Add networkConfig optional field to AgentEnvSpec
- Add superRefine cross-field validation
- Update LLM-compacted schema documentation
- Add 13 new unit tests for VPC schema validation
Add informational messages when agents use VPC network mode:
- dev command: Note that VPC networking does not apply locally
- invoke command: Guidance about required VPC Endpoints (S3, ECR,
  Bedrock) and public internet access for non-Bedrock providers
@tejaskash tejaskash requested a review from a team February 24, 2026 20:32
@github-actions github-actions bot added the size/m PR size: M label Feb 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 43.91% 2967 / 6756
🔵 Statements 43.5% 3123 / 7178
🔵 Functions 45.76% 616 / 1346
🔵 Branches 48.59% 1932 / 3976
Generated in workflow #632 for commit 9b15955 by the Vitest Coverage Report Action

@tejaskash tejaskash merged commit 7a81b02 into main Feb 24, 2026
17 of 19 checks passed
@tejaskash tejaskash deleted the feat/vpc-3-ux-messages branch February 24, 2026 23:15
tejaskash added a commit that referenced this pull request Feb 27, 2026
tejaskash added a commit that referenced this pull request Feb 27, 2026
* Revert "feat: add VPC CLI flags to create and add commands [2/3] (#425)"

This reverts commit c75f4cd.

* Revert "feat: add VPC info messages to dev and invoke commands [3/3] (#426)"

This reverts commit 7a81b02.

* Revert "feat: add VPC network mode to schema (#424)"

This reverts commit 4180646.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants