feat: make container dev mode language-agnostic#500
Merged
aidandaly24 merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
Remove Python/uvicorn-specific code from container dev mode. The container
now simply builds the user's Dockerfile and runs it without hot reloading.
Changes:
- Remove dev layer that installed uvicorn; build image directly
- Remove entrypoint/user overrides; use Dockerfile's CMD/ENTRYPOINT
- Remove source volume mount (no hot reload)
- Stream build output in real-time instead of blocking
- Use async spawn for container stop so UI can render "Stopping..."
- Add sessionId header and Accept: text/event-stream for invoke requests
- Support {"text": "..."} SSE format from bedrock-agentcore runtime
- Show "Stopping container..." instead of generic "Stopping server..."
Contributor
Coverage Report
|
aidandaly24
reviewed
Mar 6, 2026
Contributor
|
e2e test failed going to try rerunning it |
aidandaly24
approved these changes
Mar 6, 2026
Contributor
aidandaly24
left a comment
aidandaly24
left a comment
There was a problem hiding this comment.
code lgtm and the e2e tests passed now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{"text": "..."}SSE format from bedrock-agentcore runtimeChanges
{"text": "..."}SSE formatTest plan