Skip to content

fix: resolve schema paths relative to project root#523

Merged
aidandaly24 merged 1 commit intomainfrom
feat/schema-project-root-paths
Mar 9, 2026
Merged

fix: resolve schema paths relative to project root#523
aidandaly24 merged 1 commit intomainfrom
feat/schema-project-root-paths

Conversation

@tejaskash
Copy link
Contributor

Summary

  • Schema file paths (OpenAPI/Smithy) are now resolved relative to the project root (parent of agentcore/) instead of inside agentcore/
  • This allows specs/ directory to live alongside app/ and agentcore/ at the top level:
    project/
    ├── app/
    ├── agentcore/
    │   └── mcp.json
    └── specs/
        └── petstore.json
    
  • Updated path resolution in validate.ts to use dirname(configRoot)
  • Updated CLI --schema help text and TUI prompts to say "relative to project root"
  • Removed agentcore/ prefix from TUI confirm review display
  • Updated integration tests to write schema files at project root level

Test plan

  • All 2052 unit tests pass
  • All 22 integration tests pass (add-remove-gateway)
  • ESLint, prettier, typecheck all pass (pre-commit hooks)

Schema files (OpenAPI/Smithy) should live alongside `app/` and `agentcore/`
at the project root, not inside `agentcore/`. This changes path resolution
in validation, CLI flags, and TUI prompts to use `dirname(configRoot)` as
the base directory, and updates integration tests accordingly.
@tejaskash tejaskash requested a review from a team March 9, 2026 19:49
@github-actions github-actions bot added the size/s PR size: S label Mar 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.58% 3750 / 8805
🔵 Statements 42.18% 3956 / 9378
🔵 Functions 44.28% 740 / 1671
🔵 Branches 44.38% 2455 / 5531
Generated in workflow #917 for commit 1d5fde7 by the Vitest Coverage Report Action

@aidandaly24 aidandaly24 merged commit d4995cb into main Mar 9, 2026
18 of 19 checks passed
@aidandaly24 aidandaly24 deleted the feat/schema-project-root-paths branch March 9, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants