Conversation
aidandaly24
had a problem deploying
to
e2e-testing
GitHub Actions
Failure
aidandaly24
force-pushed
the
feat/enable-semantic-search
branch
from
9cfb98a to
a526cbe
Compare
…d config Extends the gateway creation TUI with observability toggle (default: ON) and debug exception level toggle (default: OFF) in the Advanced Configurations multi-select screen, following the existing semantic search pattern.
…way creation Wires observability config through the full CLI path: Commander flags → action handler → buildGatewayConfig() → gateway object in mcp.json. Uses the same --no-X boolean negation pattern as --no-semantic-search.
7 tests for GatewayPrimitive.add() observability behavior (defaults, noObservability, exceptionLevel, invalid fallback). 7 tests for useAddGatewayWizard defaults and setAdvancedConfig with observability fields.
Adds Zod-based validation for exceptionLevel in validateAddGatewayOptions(), matching the existing pattern for framework/authorizer validation. Invalid values like VERBOSE now fail with a clear error instead of silently falling back to NONE.
Widens the Transaction Search trigger from "agents exist" to "agents exist OR any gateway has observability enabled". Both CLI and TUI deploy paths now check gateway observability config from mcp.json. Adds 3 tests.
Align test cases with the positive enableObservability naming convention adopted during rebase (matching enableSemanticSearch).
Dependabot PR aws#538 bumped eslint to 10.0.3, but eslint-plugin-react 7.37.5 (latest) doesn't support ESLint 10 yet, breaking lint-staged.
…ateway schema Transaction Search is now automatic for gateways (matching agent behavior), so the observability.enabled toggle is removed. exceptionLevel is promoted from the nested observability wrapper to a direct gateway field.
Reverts unrelated Unicode/emoji formatting changes that inflated the diff, and regenerates package-lock.json properly for the eslint 9.x pin.
aidandaly24
force-pushed
the
feat/enable-semantic-search
branch
from
a526cbe to
4510fe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds gateway observability support:
exceptionLevelfield on the gateway schema and a "Debug Exception Level" toggle in the TUI wizard's advanced configuration pane.What changed:
GatewayExceptionLevelSchema('NONE' | 'DEBUG') as a direct field onAgentCoreGatewayschema--exception-level <level>CLI flag for non-interactive gateway creationhasGatewayObservabilitytohasGatewaysin deploy flow since Transaction Search triggers on gateway existenceeslintto^9.39.4because dependabot PR chore(deps-dev): bump the dev-dependencies group with 6 updates #538 bumped to v10 which is incompatible witheslint-plugin-react@7.37.5Design decisions:
exceptionLevelis a top-level gateway field (not nested under anobservabilitywrapper) to keep the schema flat and simple'NONE'(generic errors);'DEBUG'returns verbose error details for debuggingRelated Issue
Closes #
Documentation PR
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.