Conversation
notgitika
approved these changes
Mar 19, 2026
tejaskash
added a commit
that referenced
this pull request
Mar 20, 2026
Override @aws-sdk/xml-builder to 3.972.14 which sets maxTotalExpansions: Infinity when creating its XMLParser. The previous fast-xml-parser 5.5.7 override (from PR #577) introduced a default limit of 1000 entities, but large CloudFormation responses for container stacks exceed this (1175 entities), causing CDK deploy to fail with "Entity expansion limit exceeded". Also add deploy retry logic for container e2e tests (up to 3 attempts with 30s delay) and include stdout in error assertions since the CLI returns errors as JSON on stdout when using --json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI
security:auditstep fails due to two high-severity CVEs infast-xml-parser:<= 5.5.5)<= 5.5.6)The existing npm override pins
fast-xml-parserto5.3.9, which is in the vulnerable range. The override is needed because@aws-sdk/xml-builderhasn't updated itsfast-xml-parserdependency yet. Bumps the override from5.3.9→5.5.7(the patched version). The repo doesn't usefast-xml-parserdirectly — it's purely a transitive dependency of@aws-sdk/xml-builder. No breaking API changes in the5.3 → 5.5range.Related Issue
N/A — CI security audit failure, no tracking issue.
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsnpm run security:audit(npm audit --audit-level=high --omit=dev) passes with 0 vulnerabilities.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.