Skip to content

fix: bump fast-xml-parser override to 5.5.7 (CVE-2026-33036, CVE-2026-33349)#577

Merged
notgitika merged 1 commit intoaws:mainfrom
Hweinstock:fix/fast-xml-parser-cve
Mar 19, 2026
Merged

fix: bump fast-xml-parser override to 5.5.7 (CVE-2026-33036, CVE-2026-33349)#577
notgitika merged 1 commit intoaws:mainfrom
Hweinstock:fix/fast-xml-parser-cve

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Mar 19, 2026

Description

CI security:audit step fails due to two high-severity CVEs in fast-xml-parser:

The existing npm override pins fast-xml-parser to 5.3.9, which is in the vulnerable range. The override is needed because @aws-sdk/xml-builder hasn't updated its fast-xml-parser dependency yet. Bumps the override from 5.3.95.5.7 (the patched version). The repo doesn't use fast-xml-parser directly — it's purely a transitive dependency of @aws-sdk/xml-builder. No breaking API changes in the 5.3 → 5.5 range.

Related Issue

N/A — CI security audit failure, no tracking issue.

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

npm run security:audit (npm audit --audit-level=high --omit=dev) passes with 0 vulnerabilities.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions bot added the size/xs PR size: XS label Mar 19, 2026
@Hweinstock Hweinstock marked this pull request as ready for review March 19, 2026 22:21
@Hweinstock Hweinstock requested a review from a team March 19, 2026 22:21
@notgitika notgitika merged commit 41570f0 into aws:main Mar 19, 2026
18 checks passed
tejaskash added a commit that referenced this pull request Mar 20, 2026
Override @aws-sdk/xml-builder to 3.972.14 which sets
maxTotalExpansions: Infinity when creating its XMLParser. The previous
fast-xml-parser 5.5.7 override (from PR #577) introduced a default
limit of 1000 entities, but large CloudFormation responses for
container stacks exceed this (1175 entities), causing CDK deploy to
fail with "Entity expansion limit exceeded".

Also add deploy retry logic for container e2e tests (up to 3 attempts
with 30s delay) and include stdout in error assertions since the CLI
returns errors as JSON on stdout when using --json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants