feat: add advanced settings gate to agent creation wizard#593
feat: add advanced settings gate to agent creation wizard#593
Conversation
Insert a "Configure advanced settings?" Yes/No gate before network configuration in both the Create and BYO agent paths. Defaults to "No, use defaults" (Public network, no VPC), letting most users skip network config with a single Enter press. Selecting "Yes, customize" expands into the existing network mode, subnet, and security group steps.
Coverage Report
|
There was a problem hiding this comment.
Can we add unit tests for this new step logic? Also, I believe "Protocol" should also fall under Advanced... lmk what you think.
Other concerns:
State cleanup inconsistency between Generate and BYO paths
useGenerateWizard.ts clears VPC config with undefined, but AddAgentScreen.tsx clears with empty strings ''. If downstream code checks !== undefined or serializes to JSON, behavior will diverge. Should use the same sentinel value in both paths.
ADVANCED_OPTIONS has description: undefined for "Yes, customize"
Other option arrays use actual strings for all descriptions. If WizardSelect renders description without a null check, this could render "undefined" as text. Should be description: ' ' or verified against the component's rendering logic.
15 tests covering step list composition, setAdvanced routing, state cleanup on toggle, routing callbacks targeting advanced, and reset behavior.
Summary
Screenshots
Advanced gate (defaults to "No")
Default path: skips to Confirm with PUBLIC network
"Yes, customize" expands network config
Test plan