fix: update E2E test regex to match new CUSTOM_JWT client-side error#832
Merged
aidandaly24 merged 1 commit intomainfrom Apr 13, 2026
Merged
fix: update E2E test regex to match new CUSTOM_JWT client-side error#832aidandaly24 merged 1 commit intomainfrom
aidandaly24 merged 1 commit intomainfrom
Conversation
PR #817 changed invoke to fail fast client-side when a CUSTOM_JWT agent is invoked without a bearer token, producing a different error message. The E2E assertions still expected the old server-side "authorization mismatch" pattern, causing two test failures on main.
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-832-tarball/aws-agentcore-0.8.0.tgz |
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #817 changed
src/cli/commands/invoke/action.tsto fail fast client-side when a CUSTOM_JWT agent is invoked without a bearer token (and without stored client credentials for auto-fetch). The new error message:The E2E tests in
byo-custom-jwt.test.tsstill expected the old server-side error pattern (/[Aa]uthoriz(ation|er).*mismatch|different.*authorization/i), causing 2 test failures on main.This updates all 5 regex assertions (2 positive, 3 negative) to also match the new client-side message.
Related Issue
Closes #
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.