Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci neuron deltaToSparse processor #1144

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ci neuron deltaToSparse processor #1144

wants to merge 2 commits into from

Conversation

aditya-purang
Copy link
Contributor

@aditya-purang aditya-purang commented Apr 23, 2024 •
edited
Loading

Description

  • Created DeltaToSparse processor which drops 0 values delta metric datapoints.
  • Updated translators for CumulativeToDeltaProcessor for neuron metrics.
  • Added CumulativeToDelta processor and DeltaToSparse processor in gpu/neuron metric pipeline
  • Extended attributed filtering in GPU processor for neuron metrics
  • Updated unit tests

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

  1. Validated neuron metrics in test cluster
  2. Added unit tests to cover new paths

values from cloudwatch compared with the neuron monitor data, the metric went through the delta to sparse process
image

@aditya-purang aditya-purang requested a review from a team as a code owner April 23, 2024 15:38
@aditya-purang aditya-purang changed the title Ci neuron delta2sparse squashed Ci neuron deltaToSparse processor Apr 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@movence movence Awaiting requested review from movence

@straussb straussb Awaiting requested review from straussb

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aditya-purang