Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate ECR client to
aws-sdk-go-v2
.Implementation details
GetAuthorizationToken()
signature to match the v2 client'sGetAuthorizationTokenInput
, which now takes in a slice of strings instead of an array of string pointersaws-sdk-go-v2 config
andcredentials
instead of v1aws.NewConfig()
,credentials
andsession
. Configuration Loading doc for referenceinstancecreds
referring to #4446cfg.BaseEndpoint
withcfg.Endpoint
aws.StringValue
->aws.ToString
,aws.TimeValue
->aws.ToTime
,aws.IntValue
->aws.ToInt
agent
module.Testing
Github checks pass.
New tests cover the changes: no
Description for the changelog
Migrate ECR client to
aws-sdk-go-v2
.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.