refactor(chat): update chat newline messaging to prioritize ctrl+j #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
=======================================
Coverage 13.69% 13.69%
=======================================
Files 2361 2361
Lines 203706 203748 +42
Branches 184070 184112 +42
=======================================
+ Hits 27889 27912 +23
- Misses 174429 174447 +18
- Partials 1388 1389 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is ctrl+j also a popular combo on Mac? I think "command+key" is more popular |
you mean like "command+j"? That keybinding doesn't work, has to be control(^) |
mschrage
reviewed
Apr 7, 2025
| @@ -119,7 +119,7 @@ const WELCOME_TEXT: &str = color_print::cstr! {" | |||
| <em>/help</em> <black!>Show the help dialogue</black!> | |||
| <em>/quit</em> <black!>Quit the application</black!> | |||
|
|
|||
| <cyan!>Use Alt(⌥) + Enter(⏎) to provide multi-line prompts.</cyan!> | |||
| <cyan!>Use Ctrl(^) + j to provide multi-line prompts.</cyan!> | |||
There was a problem hiding this comment.
Suggested change
| <cyan!>Use Ctrl(^) + j to provide multi-line prompts.</cyan!> | |
| <cyan!>Tip: Use Ctrl(^) + j to add a newline in your prompt.</cyan!> |
mschrage
approved these changes
Apr 7, 2025
This was referenced Apr 30, 2025
Merged
Closed
mangaohua
pushed a commit
to mangaohua/amazon-q-developer-cli
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
ctrl+jsince it seems to be more commonly supported - for instance, my default keybindings already have something set for Alt+Enter across different terminals.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.