-
Notifications
You must be signed in to change notification settings - Fork 100
feat: continue Windows implementation #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
=======================================
Coverage 16.75% 16.75%
=======================================
Files 213 213
Lines 20704 20704
Branches 871 871
=======================================
Hits 3468 3468
Misses 17236 17236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for the contribution! Can you run |
Hey @brandonskiser, sorry about that! I've made the fixes |
Oh, just saw the other comments as well. I'll get those changes added |
@brandonskiser , made all of the requested changes. Let me know if I need to tweak anything else! |
} | ||
|
||
/// The q sockets directory of the local q installation | ||
/// | ||
/// - Linux: $XDG_RUNTIME_DIR/cwrun | ||
/// - MacOS: $TMPDIR/cwrun | ||
/// - Windows: %TEMP%\sockets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - comment doesn't match the actual implementation
@@ -251,6 +264,7 @@ pub fn sockets_dir() -> Result<PathBuf> { | |||
/// | |||
/// - Linux: $XDG_RUNTIME_DIR/cwrun | |||
/// - MacOS: $TMPDIR/cwrun | |||
/// - Windows: %TEMP%\sockets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, along with other comments
Windows Implementation Enhancements
This PR continues the implementation of Windows support for the Amazon Q Developer CLI by adding and improving Windows-specific functionality across several core utility modules.
Changes
Protocol Buffer Support
Directory Structure
%LOCALAPPDATA%\Fig
%LOCALAPPDATA%\Fig\resources
%LOCALAPPDATA%\Fig\bin
%LOCALAPPDATA%\Fig\sockets\figterm\$SESSION_ID.sock
Process Information
Manifest Support
Code Cleanup
Testing
Continues work on #153