generated from amazon-archives/__template_Custom
-
Couldn't load subscription status.
- Fork 342
fix: Panic on CJK character truncation in MCP prompt descriptions #3227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mzkmnk
wants to merge
8
commits into
aws:main
Choose a base branch
from
mzkmnk:fix/cjk-truncate-panic-3117-3170
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−7
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dfe7071
Fix panic on CJK character truncation in prompts
mzkmnk 8ae8d5d
Regenerate Cargo.lock to fix TOML parse error
mzkmnk b43dd79
Restore original test_truncate_description test
mzkmnk 066f6ec
refactor: code format
mzkmnk c53bdf2
test: add edge case tests for truncate_description
mzkmnk 4e1c8e5
refactor: remove redundant edge case check in truncate_description
mzkmnk e2c2a9f
chore: regenerate Cargo.lock
mzkmnk 21fb022
refactor: use truncate_safe_in_place for UTF-8 safe truncation
mzkmnk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that
truncate_safe_in_placealready exists in the codebase, so I used that instead