chore: legacy UI for new event loop #3254
Open
+942
−71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Premise:
This PR builds on top of #3112 with the following changes (and their respective reasoning)
InputSource(chat-cli crate)InputSourceis how the current event loop reads from stdin. When the ui abstraction is configured to take on the responsibility to manage input,InputSourceis no longer constructed.With this, chat has 2 dials that affect the code path of information to and from event loop:
A is the current experience. This is identical in UX to what we have now.
D is the experience we are replicating for when the new event loop lands.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.