chore: clarify cloud-assembly-schema contribution flow
#31444
Conversation
| repository for contributions. If you have a PR that needs to modify `cloud-assembly-schema`, open both PRs and | ||
| ensure that you link the `cloud-assembly-schema` PR in the one opened against this repository. |
There was a problem hiding this comment.
i don't understand what PR would be opened against aws-cdk's cloud-assembly-schema given that its just a shell for the external version.
| repository for contributions. If you have a PR that needs to modify `cloud-assembly-schema`, open both PRs and | ||
| ensure that you link the `cloud-assembly-schema` PR in the one opened against this repository. | ||
| The `cloud-assembly-schema` changes must be merged (and released) before the PR in this repository can be merged. | ||
| The PR in this repository must be updated to use the new release of the `cloud-assembly-schema` before it can be merged. |
There was a problem hiding this comment.
oh wait we don't automatically grab new versions of cloud-assembly-schema when they're released? we have to manually update the version?
a) if thats the case, is that safe from a security perspective
b) we should probably have an example/instruction for what the PR against aws-cdk repo looks like then
There was a problem hiding this comment.
We do grab new ones, it's just reliant on dependabot. I can clarify that we either have to wait for the version bump or manually bump it, but the point was that it's been approved, but it can't merge until dependabot decides to update it.
|
also if we don't monitory cdklabs/cloud-assembly-schema we should at least remove the ability to add issues |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Reason for this change
The process for merging changes to the new
cloud-assembly-schemarepository is unclear. This clarifies the process.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license