chore(secretsmanager): update GovCloud SAR version to 1.1.319 #36019
+155
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
previously requested changes
Nov 11, 2025
dwbcodes
changed the title
PASS aws-secretsmanager/test/secret-rotation.test.ts (5.892 s)
✓ secret rotation single user (386 ms)
✓ secret rotation multi user (147 ms)
✓ secret rotation allows passing an empty string for excludeCharacters (141 ms)
✓ secret rotation without immediate rotation (107 ms)
✓ throws when connections object has no default port range (53 ms)
✓ throws when master secret is missing for a multi user application (14 ms)
✓ rotation function name does not exceed 64 chars (106 ms)
✓ with interface vpc endpoint (100 ms)
SecretRotationApplication partition version
✓ returns correct version for aws partition (25 ms)
✓ returns correct version for aws-cn partition (10 ms)
✓ returns correct version for aws-us-gov partition (9 ms)
✓ throws for unsupported partition (31 ms)
✓ returns correct ARN for aws-us-gov partition (12 ms)
CloudFormation mapping for all partitions
✓ includes correct versions for all cloud types (129 ms)
✓ includes correct mapping for all rotation applications (388 ms)
Author
|
Clarification Request: I am not sure if this PR needs an integration test for a simple version modification. |
aws-cdk-automation
added
the
pr/reviewer-clarification-requested
dwbcodes
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
This was referenced Nov 15, 2025
Contributor
|
I saw this in your CI error You can try run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Updates the GovCloud (
aws-us-gov) SAR version forSecretsManagerRDSMySQLRotationSingleUserfrom1.1.213to1.1.319.Closes # N/A
Reason for this change
The current SAR version (
1.1.213) in CDK for GovCloud uses Python 3.9, which will be Deprecated Dec 15th. The newer SAR version1.1.319uses Python 3.10, which is supported until October 31, 2027.1.1.213uses Python 3.91.1.319uses Python 3.10Description of changes
SecretRotationApplicationto return1.1.319foraws-us-govpartition.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Linked my CDK app to the aws-cdk-lib and upgrade my secretsRotationLambda which is now on 3.10.
From
To
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license