-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(s3): make enableAutoDeleteObjects method public
#36066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
c19yamamoto
wants to merge
15
commits into
aws:main
Choose a base branch
from
c19yamamoto:allow-setting-auto-delete-objects-outside-constructor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(s3): make enableAutoDeleteObjects method public
#36066
c19yamamoto
wants to merge
15
commits into
aws:main
from
c19yamamoto:allow-setting-auto-delete-objects-outside-constructor
+346
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cdk-automation
previously requested changes
Nov 14, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
…of github.com:c19yamamoto/aws-cdk into allow-setting-auto-delete-objects-outside-constructor
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beginning-contributor
[Pilot] contributed between 0-2 PRs to the CDK
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
pr/needs-community-review
This PR needs a review from a Trusted Community Member or Core Team Member.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #15413
Reason for this change
The
autoDeleteObjectsfunctionality, which enables the deletion of all objects within an S3 Bucket when the CDK stack is destroyed, is currently only configurable via theautoDeleteObjectsproperty in theBucketPropsconstructor. This property requires users to decide on object cleanup behavior at the time of resource creation.The use case for this change is to enable users to activate this capability after the bucket has been created (e.g., inside an aspect, a custom method, or dynamically based on conditions), by exposing the internal logic through a public method.
Description of changes
The private method
enableAutoDeleteObjects()was changed to publicDescribe any new or updated permissions being added
none
Description of how you validated changes
Add unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license