-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(events-targets): support messageGroupId for standard SQS queues #36068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(events-targets): support messageGroupId for standard SQS queues #36068
Conversation
EventBridge now supports the messageGroupId parameter for standard (non-FIFO) SQS targets. This change removes the client-side validation that was blocking this feature. Fixes: Removes ValidationError when messageGroupId is used with standard queues Tests: Updated test to verify messageGroupId works with standard queues Docs: Updated JSDoc to reflect support for both queue types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
…sageGroupId - Added comprehensive README documentation showing messageGroupId usage for both FIFO and standard queues - Updated integration test to include messageGroupId example with standard queue - Addresses PR feedback requiring README and integration test changes
Added CloudFormation resources for standard queue with messageGroupId: - StandardQueue resource - StandardQueuePolicy with EventBridge permissions - StandardQueueRule with SqsParameters.MessageGroupId
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
The integration test "destructive changes" are intentional and expected. I've added three new resources to the integration test to demonstrate the messageGroupId feature with standard (non-FIFO) SQS queues:
These resources are necessary to validate that messageGroupId now works correctly with standard queues, which is the core functionality being added in this PR. The existing test only covered FIFO queues and encrypted queues with dead letter queues - this addition provides coverage for the new standard queue capability. |
Description
EventBridge now supports the
messageGroupIdparameter for standard (non-FIFO) SQS targets. This PR removes the client-side validation that was preventing customers from using this feature.Changes
SqsQueueconstructor that blocked messageGroupId for standard queuesBackground
The EventBridge service API has always supported messageGroupId as an optional parameter for SqsParameters, but the service validation previously rejected it for standard queues. With the recent backend service change (CR-231214910), EventBridge now accepts messageGroupId for standard SQS queues, enabling customers to use this parameter for message grouping.
Testing
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license