Skip to content

Conversation

@ravilg-aws
Copy link

Description

EventBridge now supports the messageGroupId parameter for standard (non-FIFO) SQS targets. This PR removes the client-side validation that was preventing customers from using this feature.

Changes

  • Removed validation error in SqsQueue constructor that blocked messageGroupId for standard queues
  • Updated JSDoc to clarify that messageGroupId is now supported for both FIFO and standard queues
  • Updated test from expecting an error to verifying proper CloudFormation synthesis

Background

The EventBridge service API has always supported messageGroupId as an optional parameter for SqsParameters, but the service validation previously rejected it for standard queues. With the recent backend service change (CR-231214910), EventBridge now accepts messageGroupId for standard SQS queues, enabling customers to use this parameter for message grouping.

Testing

  • Unit tests updated to verify messageGroupId works with standard queues
  • Existing FIFO queue tests continue to work
  • All existing SQS target tests pass

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

EventBridge now supports the messageGroupId parameter for standard (non-FIFO)
SQS targets. This change removes the client-side validation that was blocking
this feature.

Fixes: Removes ValidationError when messageGroupId is used with standard queues
Tests: Updated test to verify messageGroupId works with standard queues
Docs: Updated JSDoc to reflect support for both queue types
@aws-cdk-automation aws-cdk-automation requested a review from a team November 14, 2025 18:16
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Nov 14, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

…sageGroupId

- Added comprehensive README documentation showing messageGroupId usage for both FIFO and standard queues
- Updated integration test to include messageGroupId example with standard queue
- Addresses PR feedback requiring README and integration test changes
Added CloudFormation resources for standard queue with messageGroupId:
- StandardQueue resource
- StandardQueuePolicy with EventBridge permissions
- StandardQueueRule with SqsParameters.MessageGroupId
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 14, 2025 22:30

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@ravilg-aws
Copy link
Author

The integration test "destructive changes" are intentional and expected. I've added three new resources to the integration test to demonstrate the messageGroupId feature with standard (non-FIFO) SQS queues:

  • StandardQueue4A8B3C4D: A standard SQS queue
  • StandardQueuePolicyFB772D09: Queue policy granting EventBridge permissions
  • StandardQueueRule2E5F2E91: EventBridge rule configured with SqsParameters.MessageGroupId

These resources are necessary to validate that messageGroupId now works correctly with standard queues, which is the core functionality being added in this PR. The existing test only covered FIFO queues and encrypted queues with dead letter queues - this addition provides coverage for the new standard queue capability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants