-
Notifications
You must be signed in to change notification settings - Fork 16
chore(python): examples for EncryptedTable #1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of code but I think it looks good -- just add more HKeyring comments and the typos
...imes/python/DynamoDBEncryption/src/keyring/hierarchical_keyring_example/encryption_config.py
Show resolved
Hide resolved
...imes/python/DynamoDBEncryption/src/keyring/raw_ecdh_keyring_example/with_encrypted_client.py
Outdated
Show resolved
Hide resolved
...s/python/DynamoDBEncryption/src/keyring/hierarchical_keyring_example/with_encrypted_table.py
Outdated
Show resolved
Hide resolved
.../searchable_encryption/virtual_beacon_searchable_encryption_example/with_encrypted_client.py
Outdated
Show resolved
Hide resolved
...c/searchable_encryption/virtual_beacon_searchable_encryption_example/with_encrypted_table.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- just make sure CI passes (except the TODOs one), then switch base branch to python-reviewed
and merge
Co-authored-by: Lucas McDonald <[email protected]>
04b348c
to
70fa6b0
Compare
There are some CI failing on |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.