Skip to content

Automatically update bootstrap template #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025
Merged

Automatically update bootstrap template #897

merged 4 commits into from
May 8, 2025

Conversation

GarrettBeatty
Copy link
Contributor

@GarrettBeatty GarrettBeatty commented Mar 19, 2025

Issue #, if available:

Description of changes:

  1. Updated github workflow to be automatically ran every monday and will create a PR to update the CDK bootstrap template. It can also be ran manually if needed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@GarrettBeatty GarrettBeatty added the Release Not Needed Add this label if a PR does not need to be released. label Mar 19, 2025
@GarrettBeatty GarrettBeatty changed the title Automatically Update bootstrap file Automatically update bootstrap file Mar 19, 2025
@GarrettBeatty GarrettBeatty marked this pull request as ready for review March 19, 2025 17:31
@GarrettBeatty GarrettBeatty requested a review from philasmar March 19, 2025 17:31
@GarrettBeatty GarrettBeatty changed the title Automatically update bootstrap file Automatically update bootstrap template Mar 19, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.55%. Comparing base (39ebd77) to head (ad058dc).
Report is 14 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #897       +/-   ##
===========================================
+ Coverage   38.67%   63.55%   +24.88%     
===========================================
  Files         284      284               
  Lines       11040    11040               
  Branches     1537     1537               
===========================================
+ Hits         4270     7017     +2747     
+ Misses       6446     3470     -2976     
- Partials      324      553      +229     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GarrettBeatty GarrettBeatty requested a review from philasmar March 21, 2025 16:51
@GarrettBeatty GarrettBeatty marked this pull request as draft April 23, 2025 18:05
generate change file

use v8

use release workflow secret

remove whitespace from bottom

use version to detect changes

fix warning

point to specific tag

use cli for creating PR

pin more versions
@GarrettBeatty GarrettBeatty marked this pull request as ready for review May 2, 2025 18:33
@GarrettBeatty GarrettBeatty requested a review from philasmar May 2, 2025 18:33
Copy link
Contributor

@philasmar philasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't be removing the existing one. We could merge a PR and release when a bootstrap template has been added but the new cron job still hasn't run. We should have both.

@GarrettBeatty GarrettBeatty requested a review from philasmar May 6, 2025 20:24
@GarrettBeatty
Copy link
Contributor Author

You shouldn't be removing the existing one. We could merge a PR and release when a bootstrap template has been added but the new cron job still hasn't run. We should have both.

good point. fixed

@GarrettBeatty GarrettBeatty merged commit 0ae6338 into dev May 8, 2025
10 checks passed
@GarrettBeatty GarrettBeatty deleted the autobootstrap branch May 8, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Not Needed Add this label if a PR does not need to be released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants