Skip to content

Conversation

philasmar
Copy link
Contributor

Issue #, if available:
DOTNET-8095

Description of changes:

  • Upgrade templating engine from .NET5 to .NET8 since a lot of changes have happened to their public interfaces

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar requested review from normj and GarrettBeatty May 7, 2025 16:52
@philasmar philasmar added the Release Not Needed Add this label if a PR does not need to be released. label May 7, 2025
@philasmar philasmar force-pushed the asmarp/update-sdk-v4 branch from 7d4137c to c905920 Compare May 8, 2025 02:12
Base automatically changed from asmarp/update-sdk-v4 to feature/net8-upgrade May 8, 2025 12:55
@philasmar philasmar force-pushed the asmarp/upgrade-templating-engine branch from 61e030a to 99d3b6d Compare May 8, 2025 12:56
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/net8-upgrade@346b5c1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/AWS.Deploy.Orchestration/TemplateEngine.cs 85.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             feature/net8-upgrade     #927   +/-   ##
=======================================================
  Coverage                        ?   62.13%           
=======================================================
  Files                           ?      294           
  Lines                           ?    10748           
  Branches                        ?     1602           
=======================================================
  Hits                            ?     6678           
  Misses                          ?     3482           
  Partials                        ?      588           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philasmar philasmar merged commit ee68ddd into feature/net8-upgrade May 8, 2025
10 checks passed
@philasmar philasmar deleted the asmarp/upgrade-templating-engine branch May 8, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Not Needed Add this label if a PR does not need to be released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants