Validate the interface name against a list of prefixes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
reviewed
Feb 13, 2025
| if !strings.HasPrefix(interfaceName, interfacePrefix) { | ||
| log.Errorf("expected prefix - %s but got %s", interfacePrefix, interfaceName) | ||
| return errors.New("Mismatched initialized prefix name and passed interface name") | ||
| func mismatchedInterfacePrefix(interfaceName string, interfacePrefix []string) error { |
There was a problem hiding this comment.
You will have update this - https://github.com/aws/aws-ebpf-sdk-go/blob/main/pkg/tc/tc_test.go#L99
jaydeokar
force-pushed
the
fix_prefix_check
branch
from
9a7e453 to
135349f
Compare
jaydeokar
force-pushed
the
fix_prefix_check
branch
from
481f161 to
11e466a
Compare
jaydeokar
force-pushed
the
fix_prefix_check
branch
from
11e466a to
d197a87
Compare
jayanthvn
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
This accepts a list of interface prefixes to TC class. If the interface doesn't start from any of the accepted list of prefixes we return an error and skip any actions on that interface
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.