Zip symlinks-to-directories #547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #511
Resolves #69
Description of changes:
This restores partially commit 790cde6, which effectively prevents including symlinks to directories as pointed out in #511.
The function
is_parent_directory_in_ignore_listwas removed because it was doing a very inefficient M*N lookup (M: number of dirs and files, N: number of entries in ignore_list which include all subdirectories and files). This part was not restored.Manual testing:
Done with Python 3.9.18 and Python 3.12.10
Set up the following local directories
Ran the following code to validate the content of the zip:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.