Skip to content

Conversation

rishav-karanjit
Copy link
Member

@rishav-karanjit rishav-karanjit commented Jul 22, 2025

Issue #, if available:

Description of changes:
Test run for release workflow: https://github.com/aws/aws-encryption-sdk/actions/runs/17309483179

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rishav-karanjit rishav-karanjit changed the title chore(go): add Go release script chore(go): add Go release workflow Aug 4, 2025
@rishav-karanjit rishav-karanjit marked this pull request as ready for review August 12, 2025 18:59
@rishav-karanjit rishav-karanjit requested a review from a team as a code owner August 12, 2025 18:59
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a q; but lgtm


- name: Run Go release automation script
run: |
chmod +x mpl/scripts/go-release-automation.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q; why not make this an executable and check it in instead of having to change it-flight?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did think about it and it might be better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway this is a nit so I merged it.

@rishav-karanjit rishav-karanjit merged commit fe49c73 into mainline Aug 29, 2025
90 checks passed
@rishav-karanjit rishav-karanjit deleted the rishav/releaseScript branch August 29, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants