-
Notifications
You must be signed in to change notification settings - Fork 22
chore(go): add Go release workflow #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ryption-sdk-dafny into rishav/releaseScript
…ryption-sdk-dafny into rishav/releaseScript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a q; but lgtm
|
||
- name: Run Go release automation script | ||
run: | | ||
chmod +x mpl/scripts/go-release-automation.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q; why not make this an executable and check it in instead of having to change it-flight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did think about it and it might be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyway this is a nit so I merged it.
Issue #, if available:
Description of changes:
Test run for release workflow: https://github.com/aws/aws-encryption-sdk/actions/runs/17309483179
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.