Request response workspace#545
Merged
bretambrose merged 82 commits intomainfrom Jul 10, 2025
Merged
Conversation
- Add tests for Greengrass samples: IPC and discovery. - Add new CI job for Greengrass tests.
* Bump braces from 3.0.2 to 3.0.3 Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * update dependency --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ws](https://github.com/websockets/ws) from 7.5.9 to 7.5.10. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.5.9...7.5.10) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <aws-sdk-common-runtime@amazon.com>
* Add refresh field to GetSecretValueRequest
Co-authored-by: GitHub Actions <aws-sdk-common-runtime@amazon.com>
added 20 commits
March 7, 2025 13:03
xiazhvera
reviewed
Jun 30, 2025
| } else if (err instanceof CrtError) { | ||
| reject(createServiceError("??", err as CrtError)); | ||
| } else { | ||
| reject(createServiceError((err as Error).toString())); |
Contributor
There was a problem hiding this comment.
If deserialization fails, the error currently falls into createServiceError((err as Error).toString()), but this might be misleading since it's not actually a service error. Should we consider handling deserialization errors through a different path or introduce a separate error type for clarity?
Contributor
Author
There was a problem hiding this comment.
Service error is a wrapper for every failure possibility. The contract is that failure always gives you a service error, and digging inside gives more details. That being said, the "??" needs to be fixed.
sbSteveK
reviewed
Jun 30, 2025
sbSteveK
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.