-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQS event source support for TestTool #2008
Open
normj
wants to merge
15
commits into
dev
Choose a base branch
from
normj/testtool-sqs
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm tracking down why the integ tests are failing in CI but not locally. |
f5b23de
to
5cc0850
Compare
5cc0850
to
2eca321
Compare
Tools/LambdaTestTool-v2/src/Amazon.Lambda.TestTool/Amazon.Lambda.TestTool.csproj
Outdated
Show resolved
Hide resolved
...ol-v2/src/Amazon.Lambda.TestTool/Processes/SQSEventSource/SQSEventSourceBackgroundService.cs
Outdated
Show resolved
Hide resolved
...mbdaTestTool-v2/src/Amazon.Lambda.TestTool/Processes/SQSEventSource/SQSEventSourceProcess.cs
Show resolved
Hide resolved
philasmar
reviewed
Mar 19, 2025
Tools/LambdaTestTool-v2/src/Amazon.Lambda.TestTool/Amazon.Lambda.TestTool.csproj
Outdated
Show resolved
Hide resolved
...ol-v2/src/Amazon.Lambda.TestTool/Processes/SQSEventSource/SQSEventSourceBackgroundService.cs
Outdated
Show resolved
Hide resolved
...ol-v2/src/Amazon.Lambda.TestTool/Processes/SQSEventSource/SQSEventSourceBackgroundService.cs
Outdated
Show resolved
Hide resolved
...ol-v2/src/Amazon.Lambda.TestTool/Processes/SQSEventSource/SQSEventSourceBackgroundService.cs
Outdated
Show resolved
Hide resolved
...ambdaTestTool-v2/src/Amazon.Lambda.TestTool/Processes/SQSEventSource/SQSEventSourceConfig.cs
Outdated
Show resolved
Hide resolved
...ambdaTestTool-v2/src/Amazon.Lambda.TestTool/Processes/SQSEventSource/SQSEventSourceConfig.cs
Show resolved
Hide resolved
...mbdaTestTool-v2/src/Amazon.Lambda.TestTool/Processes/SQSEventSource/SQSEventSourceProcess.cs
Outdated
Show resolved
Hide resolved
...mbdaTestTool-v2/src/Amazon.Lambda.TestTool/Processes/SQSEventSource/SQSEventSourceProcess.cs
Show resolved
Hide resolved
...mbdaTestTool-v2/src/Amazon.Lambda.TestTool/Processes/SQSEventSource/SQSEventSourceProcess.cs
Outdated
Show resolved
Hide resolved
GarrettBeatty
approved these changes
Mar 24, 2025
philasmar
approved these changes
Mar 26, 2025
Could you take another look at the CI for this PR? I reran it again and it seems like the tests are hanging in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/integrations-on-dotnet-aspire-for-aws#41
Description of changes:
Adds the ability to add an SQS queue as an event source within the test tool. The outline of the control flow is
SQSEventSourceBackgroundService
which is anIHostedService
will be created for each configured SQS event source.The configuration is controlled by the
--sqs-eventsource-config
switch. The default format is comma delimited key pairs. For exampleQueueUrl=<queue-url>,FunctionName=<function-name>,VisibilityTimeout=100
. To add consistency with the API Gatway environment variable support it also supports JSON format. The JSON format also supports an array of configs to spin up multiple event sources. Using JSON on the command line is awkward though because you have to handle escaping quotes and using the comma delimited key pairs format avoids that.For Aspire I need to pass the config via an environment variable. I introduced the idea that could be expanded later that if the value for
--sqs-eventsource-config
starts withenv:
then the tool will look for the config in the environment variables in the suffix of the value.An example of the .NET Aspire experience
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.