Skip to content

Deleting integration tests #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/workflows/test-on-push-and-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,4 @@ jobs:
docker build -f test/unit/Dockerfile.nodejs${{ matrix.node-version }}.x -t unit/nodejs.${{ matrix.node-version }}x .
docker run unit/nodejs.${{ matrix.node-version }}x

integration-test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
distro: [alpine, amazonlinux, centos, debian, ubuntu]

steps:
- uses: actions/checkout@v4
- name: Run ${{ matrix.distro }} integration tests
run: DISTRO=${{ matrix.distro }} make test-integ
13 changes: 2 additions & 11 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,6 @@ init:
test:
npm run test

setup-codebuild-agent:
docker build -t codebuild-agent - < test/integration/codebuild-local/Dockerfile.agent

test-smoke: setup-codebuild-agent
CODEBUILD_IMAGE_TAG=codebuild-agent test/integration/codebuild-local/test_one.sh test/integration/codebuild/buildspec.os.alpine.1.yml alpine 3.16 18

test-integ: setup-codebuild-agent
CODEBUILD_IMAGE_TAG=codebuild-agent DISTRO="$(DISTRO)" test/integration/codebuild-local/test_all.sh test/integration/codebuild

copy-files:
npm run copy-files

Expand All @@ -30,7 +21,7 @@ format:
dev: init test

# Verifications to run before sending a pull request
pr: build dev test-smoke
pr: build dev

clean:
npm run clean
Expand All @@ -42,7 +33,7 @@ build: copy-files
pack: build
npm pack

.PHONY: target init test setup-codebuild-agent test-smoke test-integ install format dev pr clean build pack copy-files
.PHONY: target init test install format dev pr clean build pack copy-files

define HELP_MESSAGE

Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,6 @@ make init build
```
Then,
* to run unit tests: `make test`
* to run integration tests: `make test-integ`
* to run smoke tests: `make test-smoke`

### Raising a PR
When modifying dependencies (`package.json`), make sure to:
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions test/integration/codebuild-local/Dockerfile.agent

This file was deleted.

206 changes: 0 additions & 206 deletions test/integration/codebuild-local/codebuild_build.sh

This file was deleted.

70 changes: 0 additions & 70 deletions test/integration/codebuild-local/test_all.sh

This file was deleted.

Loading