Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate 3rd batch of CI jobs #2183

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nhatnghiho
Copy link
Contributor

Description of changes:

This PR migrates jobs that require ipv6 enabled in CodeBuild to run properly (with nmap being a special add-on to balance out the size of the next batch of jobs).

The jobs to be migrated in this PR are:

  • grpc
  • bind9
  • strongswan
  • openvpn2.6
  • openvpnMaster
  • nmap

Call-outs:

In this PR, I changed the build directory of bind9 to resolve a character limit issue in CodeBuild.

In one of its tests, bind9 will try to create a socket with a path deep within the build directory. Since CodeBuild's build directory is already very long, the combined socket path length will exceed the Linux limit of 108 characters. Therefore, I had to reduce the length of the build directory to mitigate this issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@nhatnghiho nhatnghiho requested a review from a team as a code owner February 8, 2025 02:03
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (df47b42) to head (49703e2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2183      +/-   ##
==========================================
+ Coverage   79.00%   79.02%   +0.02%     
==========================================
  Files         611      612       +1     
  Lines      105904   106072     +168     
  Branches    14984    14994      +10     
==========================================
+ Hits        83665    83824     +159     
- Misses      21586    21595       +9     
  Partials      653      653              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants