build: Remove libnccl-net before creating symlink #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f71aea2 changed the default library name from libnccl-net.so to libnccl-net-ofi.so, and then created a symlink from libnccl-net-ofi.so to libnccl-net.so. The commit missed the upgrade path, where the install directory already contained a libnccl-net.so file, causing the symlink creation to fail. This commit removes the libnccl-net.so file/symlink before creating the symlink, fixing the upgrade path. Signed-off-by: Brian Barrett <[email protected]>
|
Sigh; this was a dumb bug. Sorry everyone. |
mozarhua
approved these changes
Mar 20, 2025
yexiang-aws
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f71aea2 changed the default library name from libnccl-net.so to libnccl-net-ofi.so, and then created a symlink from libnccl-net-ofi.so to libnccl-net.so. The commit missed the upgrade path, where the install directory already contained a libnccl-net.so file, causing the symlink creation to fail.
This commit removes the libnccl-net.so file/symlink before creating the symlink, fixing the upgrade path.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.