Skip to content

Fix error header for bidirectional streaming models #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Apr 24, 2025

Issue #, if available:
Modeled errors that can be represented using a common error shape are not generated in CPP SDK, but still were referenced on some supposedly unused headers.
These unused headers is a different issue to be fixed.

Description of changes:
Change the type of certain errors referenced so they do exist.
Tested using #3391

PS: I've also tried to generate the following block in the errors header:

namespace Model {
using BadRequestException = Aws::Client::AWSError<TranscribeStreamingServiceErrors>;
using ConflictException = Aws::Client::AWSError<TranscribeStreamingServiceErrors>;
using InternalFailureException = Aws::Client::AWSError<TranscribeStreamingServiceErrors>;
using LimitExceededException = Aws::Client::AWSError<TranscribeStreamingServiceErrors>;
using ResourceNotFoundException = Aws::Client::AWSError<TranscribeStreamingServiceErrors>;
using ServiceUnavailableException = Aws::Client::AWSError<TranscribeStreamingServiceErrors>;
}  // namespace Model

However, the problem is that this block would be generated for almost any service present, unless a more complicated logic (if such error is present AND referenced by some other shape) is required to avoid huge diff.
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin SergeyRyabinin force-pushed the sr/fixBidiHeadersBuild branch from 94f5bd9 to 66b154a Compare April 24, 2025 18:10
SergeyRyabinin added a commit that referenced this pull request Apr 24, 2025
@SergeyRyabinin SergeyRyabinin force-pushed the sr/fixBidiHeadersBuild branch from 2747b69 to 433bd47 Compare April 24, 2025 19:56
@SergeyRyabinin SergeyRyabinin marked this pull request as ready for review April 24, 2025 19:56
@SergeyRyabinin SergeyRyabinin merged commit 8fac9c6 into main Apr 24, 2025
4 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/fixBidiHeadersBuild branch April 24, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants