Fix error header for bidirectional streaming models #3393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Modeled errors that can be represented using a common error shape are not generated in CPP SDK, but still were referenced on some supposedly unused headers.
These unused headers is a different issue to be fixed.
Description of changes:
Change the type of certain errors referenced so they do exist.
Tested using #3391
PS: I've also tried to generate the following block in the errors header:
However, the problem is that this block would be generated for almost any service present, unless a more complicated logic (if such error is present AND referenced by some other shape) is required to avoid huge diff.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.