Fix data received handler for winhttp #3580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
force-pushed
the
stream-buf-protected-write-callback
branch
from
c0febb1 to
458c326
Compare
sbiscigl
changed the title
sbiscigl
force-pushed
the
stream-buf-protected-write-callback
branch
from
458c326 to
993f194
Compare
sbiscigl
force-pushed
the
stream-buf-protected-write-callback
branch
8 times, most recently
from
0b2df59 to
d11b3be
Compare
pulimsr
approved these changes
Oct 14, 2025
kai-ion
approved these changes
Oct 14, 2025
sbiscigl
force-pushed
the
stream-buf-protected-write-callback
branch
from
d11b3be to
004b7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We accidentally changed the behavior of the
DataReceivedEventHandlercallback in #2954 for the windows http client. When we changed to buffer the input inStreamBufProtectedWriter, when we call theDataReceivedEventHandlerin the writer function, the response body has not been updated yet, it is still in the temp buffer in the wrapper object. This causes the callback to see no data in the response stream.This updates the code to work as it worked before by adding a
WriteCompleteCallbackinStreamBufProtectedWriterthat can be called after the response buffer has been written to.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.