Skip to content

URI Cache for DynamoDB Account Id based Endpoints #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented Jul 8, 2025

Motivation and Context

Add caching for account id based endpoint in front of the URI constructors

Continuation of #6087 and #6228

  • Replacing LruCache with a random-eviction BoundedCache in SdkUri
  • Cache size of 150
  • When full, performs batch eviction of 10 entries (arbitrarily chosen)

Modifications

  • Added a SdkURI class which caches calls to the various URI constructors methods.
  • Added customization configuration to codegen to enable usage of SdkURI class in generated endpoint resolution code.
  • Enabled this config only for DynamoDB.

Testing

  • Unit test
  • Performance tests and profiling
  • Canary tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

@davidh44 davidh44 requested a review from a team as a code owner July 8, 2025 17:05
Copy link
Contributor

@RanVaknin RanVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments. This looks good

Copy link

sonarqubecloud bot commented Jul 9, 2025

@davidh44 davidh44 added this pull request to the merge queue Jul 10, 2025
Merged via the queue into master with commit f727239 Jul 10, 2025
34 of 35 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants