Skip to content

chore(codegen): update smithy to 1.56.0 #7020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore(codegen): update smithy to 1.56.0 #7020

wants to merge 2 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 18, 2025

Issue

Internal JS-5849

Description

Updates smithy CLI to 1.56.0

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr

This comment was marked as off-topic.

@trivikr
Copy link
Member Author

trivikr commented Apr 18, 2025

The HttpEmptyPrefixHeadersRequestClient protocol test is failing

 FAIL  test/functional/restxml.spec.ts > HttpEmptyPrefixHeadersRequestClient:Request
AssertionError: expected 'Hello' to be 'There' // Object.is equality

Expected: "There"
Received: "Hello"

 ❯ test/functional/restxml.spec.ts:1451:32
    1449| 
    1450|     expect(r.headers["hello"]).toBeDefined();
    1451|     expect(r.headers["hello"]).toBe("There");
       |                                ^
    1452|     expect(r.headers["x-foo"]).toBeDefined();
    1453|     expect(r.headers["x-foo"]).toBe("Foo");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant