Skip to content

fix(s3): Force pathstyle when detecting custom endpoint url #7137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Draft

fix(s3): Force pathstyle when detecting custom endpoint url #7137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f902002
Force pathstyle when detecting custom endpoint unless s3-prefixed
joe4dev Jun 12, 2025
9c2f63b
Fix type error and switch to undefined/auto detection
joe4dev Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion clients/client-s3/src/endpoint/EndpointParameters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,16 @@ export type ClientResolvedEndpointParameters = ClientInputEndpointParameters & {
export const resolveClientEndpointParameters = <T>(
options: T & ClientInputEndpointParameters
): T & ClientResolvedEndpointParameters => {
// Custom endpoints are incompatible with virtual-host-style, unless
// the endpoint includes "s3." to allow for virtual-host-style testing.
let forcePathStyleOverride = undefined;
if (options.endpoint && !options.useAccelerateEndpoint) {
forcePathStyleOverride = options.forcePathStyle ?? true;
}
return Object.assign(options, {
useFipsEndpoint: options.useFipsEndpoint ?? false,
useDualstackEndpoint: options.useDualstackEndpoint ?? false,
forcePathStyle: options.forcePathStyle ?? false,
forcePathStyle: options.forcePathStyle ?? forcePathStyleOverride ?? false,
useAccelerateEndpoint: options.useAccelerateEndpoint ?? false,
useGlobalEndpoint: options.useGlobalEndpoint ?? false,
disableMultiregionAccessPoints: options.disableMultiregionAccessPoints ?? false,
Expand Down