chore: install biomejs cli #7139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Jun 19, 2025
| "maxSize": 16000000, | ||
| "includes": ["{packages,lib,scripts,tests}/**/*.{mjs,js,ts,json}", "!**/dist-{cjs,es,types}/**", "!**/ruleset.ts"] | ||
| }, | ||
| "formatter": { |
There was a problem hiding this comment.
I've turned many rules off initially because we need to establish that biome is runnable in our build systems before reintroducing rules that would lead to code changes.
kuhe
force-pushed
the
biome2
branch
3 times, most recently
from
bae8ce1 to
6a36ea7
Compare
kuhe
commented
Jun 19, 2025
| "suspicious": "off" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
because biome requires that subconfiguration must also be named biome.json rather than allowing a pointer to a custom config file, and that it must sit in the folder it has control over, I had to edit several scripts that scan the clients folder to exclude this file.
siddsriv
approved these changes
Jun 19, 2025
trivikr
requested changes
Jun 19, 2025
Co-authored-by: Trivikram Kamat <[email protected]>
trivikr
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs biomejs v2.0.0 and a preliminary configuration, but does not use it in any build steps.
Prior experimentation:
#7134