Validate security credentials obtained from Instance Metadata Service #3203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting security credentials from Instance Metadata Service fails when an EC2 instance does not have permissions to assume a role. When that happens, we get a very unhelpful error message "Value cannot be null. (Parameter 'awsAccessKeyId')" Do response validation so that we get better exception message. See also aws/aws-cli#2060
|
The change needs to be tested in all compute environments (like EC2, ECS, EKS, etc.). |
|
Reviewed the PR with the team. The unit tests are broken and dry run is failing. This needs to be reworked internally. |
|
I'm going to close this PR as Ashish mentioned there are some tests that are broken with this change. We're also currently working on other IMDS changes, and we'll re-evaluate whether the fix can be included there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Getting security credentials from Instance Metadata Service fails when an EC2 instance does not have permissions to assume a role. When that happens, we get a very unhelpful error message
Value cannot be null. (Parameter 'awsAccessKeyId')Do response validation so that we get better exception message.See also aws/aws-cli#2060
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
License