Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure repo layout to clarify feature vertical boundaries #4132

Merged
merged 14 commits into from
Feb 23, 2024

Conversation

rli
Copy link
Contributor

@rli rli commented Feb 12, 2024

Along the lines of aws/aws-toolkit-vscode#4342,

We split the structure of the repo to prepare for multiple extensions out of a single monorepo.
This is only a subset of changes to hopefully keep merge conflicts minimal as we migrate buildscripts and further move code between directories.

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rli
Copy link
Contributor Author

rli commented Feb 12, 2024

/runUiTests

rli added 5 commits February 15, 2024 16:48
 Conflicts:
	plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/ideMaven/MavenRunnerUtils.kt
	plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/model/MavenCopyCommandsResult.kt
@rli rli changed the title [draft] Restructure repo layout to clarify feature vertical boundaries Restructure repo layout to clarify feature vertical boundaries Feb 20, 2024
afterSync(":sdk-codegen:generateSdks")
afterSync(":jetbrains-core:generateTelemetry")
afterSync(":plugin-core:sdk-codegen:generateSdks")
afterSync(":plugin-toolkit:jetbrains-core:generateTelemetry")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be a part of plugin-core?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is more involved so will happen later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an empty file, is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe the path needs to exist you can't commit an empty folder
this should probably handled a different way but is not in scope for this PR

@rli rli marked this pull request as ready for review February 20, 2024 21:43
@rli rli requested review from a team as code owners February 20, 2024 21:43
rli and others added 5 commits February 20, 2024 14:24
 Conflicts:
	plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/QTelemetryUtils.kt
jetbrains-core/bin/
jetbrains-ultimate/bin/
resources/bin/
jetbrains-rider/**/NuGet.config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these path names need to be changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can adjust again if we change the paths again, but it shouldn't be necessary

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18 Security Hotspots
3.0% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@rli rli merged commit 29a635e into main Feb 23, 2024
16 of 19 checks passed
@rli rli deleted the rli/repo-relayout branch February 23, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants