-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure repo layout to clarify feature vertical boundaries #4132
Conversation
/runUiTests |
Conflicts: plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/ideMaven/MavenRunnerUtils.kt plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codemodernizer/model/MavenCopyCommandsResult.kt
afterSync(":sdk-codegen:generateSdks") | ||
afterSync(":jetbrains-core:generateTelemetry") | ||
afterSync(":plugin-core:sdk-codegen:generateSdks") | ||
afterSync(":plugin-toolkit:jetbrains-core:generateTelemetry") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be a part of plugin-core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is more involved so will happen later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an empty file, is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe the path needs to exist you can't commit an empty folder
this should probably handled a different way but is not in scope for this PR
Conflicts: plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/QTelemetryUtils.kt
jetbrains-core/bin/ | ||
jetbrains-ultimate/bin/ | ||
resources/bin/ | ||
jetbrains-rider/**/NuGet.config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these path names need to be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can adjust again if we change the paths again, but it shouldn't be necessary
|
Along the lines of aws/aws-toolkit-vscode#4342,
We split the structure of the repo to prepare for multiple extensions out of a single monorepo.
This is only a subset of changes to hopefully keep merge conflicts minimal as we migrate buildscripts and further move code between directories.
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.