Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): implement workspace file messages #5377

Draft
wants to merge 14 commits into
base: feature/q-lsp
Choose a base branch
from

Conversation

samgst-amazon
Copy link
Contributor

Implement both

  • workspace/didCreateFiles
  • workspace/didDeleteFiles

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Set up a messageBus listener to listen for VFileEvents for both file creation and deletion, sends appropriate messages in both cases.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samgst-amazon samgst-amazon changed the base branch from main to feature/q-lsp February 14, 2025 01:32
@samgst-amazon
Copy link
Contributor Author

still trying to get unit tests working, didChangeWorkspaceFolders is a little bit trickier and needs its own PR

Copy link

github-actions bot commented Feb 14, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

CreateFilesParams().apply {
files = events.map { event ->
FileCreate().apply {
uri = event.file?.toNioPath()?.toUri().toString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make a util for virtualfile -> URI because we will likely have a lot of edge cases to deal with

CreateFilesParams().apply {
files = events.map { event ->
FileCreate().apply {
uri = event.file?.toNioPath()?.toUri().toString()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is no file we should not emit an event

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought this would be handled by if (events.isNotEmpty()) for both messages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess i meant if the uri is null then we shouldn't emit an event because that doesn't seem useful

@rli
Copy link
Contributor

rli commented Feb 14, 2025

do we even need didChangeWorkspaceFolders?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants