ci: UI test for feature availability in chat panel #5393
+351
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
reviewed
Feb 19, 2025
ui-tests-starter/tst-243+/software/aws/toolkits/jetbrains/uitests/chatTests/TestCaseScripts.kt
Show resolved
Hide resolved
| .useDriverAndCloseIde { | ||
| waitForProjectOpen() | ||
| // required wait time for the system to be fully ready | ||
| Thread.sleep(30000) |
There was a problem hiding this comment.
isnt there a wait for index done or something?
There was a problem hiding this comment.
There is a waitForIndicator() but that doesn't still doesn't add enough time
| assertTrue(result.contains("/review")) | ||
| assertTrue(result.contains("/test")) | ||
|
|
||
| Thread.sleep(20000) |
There was a problem hiding this comment.
I get the first sleep but why the one here?
There was a problem hiding this comment.
This one was mainly so that we could capture the exact output on the textbox cause otherwise it ends instantaneously. It doesnt need to be 20000 though, I'll try to make it shorter.
samgst-amazon
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.