feat(lsp): respect IDE user proxy settings / forward trust store #5553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rli merged 19 commits into feature/q-lsp-chat from rli/lsp-proxy

May 8, 2025

Contributor

rli commented Apr 10, 2025

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Description

Checklist

My code follows the code style of this project
I have added tests to cover my changes
A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.


          wip: feature(lsp): respect IDE user proxy settings / forward trust store

82f7313

github-actions bot commented Apr 10, 2025 •

edited

Loading

Qodana Community for JVM

7 new problems were found

Inspection name	Severity	Problems
`Usage of API marked for removal`	🔴 Failure	7

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

github-advanced-security bot found potential problems

View reviewed changes

...tbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt Fixed Show fixed Hide fixed

...tbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt Fixed Show fixed Hide fixed

...tbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt Fixed Show fixed Hide fixed

...tbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt Fixed Show fixed Hide fixed

rli and others added 2 commits

April 10, 2025 17:21


          Merge branch 'feature/q-lsp' into rli/lsp-proxy

cf0ba75


          hook up

b8dcb4d

github-advanced-security bot found potential problems

View reviewed changes

...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt Fixed Show fixed Hide fixed

...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt

+                                      put(
+                                          "HTTPS_PROXY",
+                                          URIBuilder("http://${address.hostname}:${address.port}").apply {
+                                              val login = HttpConfigurable.getInstance().proxyLogin

Check failure

Code scanning / QDJVMC

Usage of API marked for removal Error

'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal

...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt

+                                      put(
+                                          "HTTPS_PROXY",
+                                          URIBuilder("http://${address.hostname}:${address.port}").apply {
+                                              val login = HttpConfigurable.getInstance().proxyLogin

Check failure

Code scanning / QDJVMC

Usage of API marked for removal Error

'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal

...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt

+                                      put(
+                                          "HTTPS_PROXY",
+                                          URIBuilder("http://${address.hostname}:${address.port}").apply {
+                                              val login = HttpConfigurable.getInstance().proxyLogin

Check failure

Code scanning / QDJVMC

Usage of API marked for removal Error

'getProxyLogin()' is deprecated and marked for removal

...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt

+                                          URIBuilder("http://${address.hostname}:${address.port}").apply {
+                                              val login = HttpConfigurable.getInstance().proxyLogin
+                                              if (login != null) {
+                                                  setUserInfo(login, HttpConfigurable.getInstance().plainProxyPassword)

Check failure

Code scanning / QDJVMC

Usage of API marked for removal Error

'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal

...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt

+                                          URIBuilder("http://${address.hostname}:${address.port}").apply {
+                                              val login = HttpConfigurable.getInstance().proxyLogin
+                                              if (login != null) {
+                                                  setUserInfo(login, HttpConfigurable.getInstance().plainProxyPassword)

Check failure

Code scanning / QDJVMC

Usage of API marked for removal Error

'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal

...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt

+                                          URIBuilder("http://${address.hostname}:${address.port}").apply {
+                                              val login = HttpConfigurable.getInstance().proxyLogin
+                                              if (login != null) {
+                                                  setUserInfo(login, HttpConfigurable.getInstance().plainProxyPassword)

Check failure

Code scanning / QDJVMC

Usage of API marked for removal Error

'getPlainProxyPassword()' is deprecated and marked for removal

aws-toolkit-automation and others added 4 commits

April 18, 2025 11:27


          Merge main into feature/q-lsp

0f73bf6


          Merge main into feature/q-lsp

3328c9f


          Merge main into feature/q-lsp

8b08e5c


          Merge branch 'feature/q-lsp' into rli/lsp-proxy

92e93b4

rli deleted the branch feature/q-lsp-chat

April 18, 2025 19:44

rli closed this

rli reopened this

rli changed the base branch from feature/q-lsp to main

April 18, 2025 19:47

rli and others added 7 commits

April 18, 2025 13:16


          configurable

548fa25


          Merge remote-tracking branch 'origin/main' into rli/lsp-proxy

ed5f0c8

wip

57ecb8b


          Merge remote-tracking branch 'origin/main' into rli/lsp-proxy

fb46994

wip

c243301

tst

37fd987


          Merge branch 'main' into rli/lsp-proxy

a7e7872

rli changed the title ~~wip: feature(lsp): respect IDE user proxy settings / forward trust store~~ feature(lsp): respect IDE user proxy settings / forward trust store

rli marked this pull request as ready for review

April 25, 2025 18:57

rli requested a review from a team as a code owner

April 25, 2025 18:57

github-advanced-security bot found potential problems

View reviewed changes

...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt Fixed Show fixed Hide fixed

...tbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt Fixed Show fixed Hide fixed


          lint

manodnyab approved these changes

View reviewed changes

...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt Outdated

                   init {
                       // will cause slow service init, but maybe fine for now. will not block UI since fetch/extract will be under background progress
                       val artifact = runBlocking { ArtifactManager(project, manifestRange = null).fetchArtifact() }.toAbsolutePath()
+                      // more slowness

Contributor

manodnyab May 6, 2025

nit: slowness added to which process?

rli and others added 3 commits

May 6, 2025 19:49


          Merge branch 'main' into rli/lsp-proxy

ecf1779


          Merge branch 'main' into rli/lsp-proxy

190427f


          build

1644d96

github-advanced-security bot found potential problems

View reviewed changes

...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt

@@ @@ -20,6 +20,8 @@ @@
               import com.intellij.openapi.util.Key
               import com.intellij.openapi.util.SystemInfo
               import com.intellij.util.io.await
+              import com.intellij.util.net.HttpConfigurable

Check failure

Code scanning / QDJVMC

Usage of API marked for removal Error

'com.intellij.util.net.HttpConfigurable' is deprecated and marked for removal

rli changed the base branch from main to feature/q-lsp-chat

May 8, 2025 19:34


          Merge branch 'feature/q-lsp-chat' into rli/lsp-proxy

9fd2e21

rli changed the title ~~feature(lsp): respect IDE user proxy settings / forward trust store~~ feat(lsp): respect IDE user proxy settings / forward trust store

rli merged commit 20f1abc into feature/q-lsp-chat

10 of 16 checks passed

rli deleted the rli/lsp-proxy branch

May 8, 2025 20:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet