Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move toolkit to monorepo structure #4342

Merged
merged 35 commits into from
Feb 6, 2024
+4,891 −4,674
Merged

refactor: move toolkit to monorepo structure #4342

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
ee06aba
initial restructure
hayemaxi Jan 25, 2024
00f58a3
some initial changes to scripts, package jsons
hayemaxi Jan 25, 2024
681feb5
build script updates
hayemaxi Jan 26, 2024
65f7b0e
fix references and remove createRelease from root package.json
hayemaxi Jan 26, 2024
b706495
fix up . config files and move .vscodeignore to toolkit package
hayemaxi Jan 26, 2024
865831a
update scripts
hayemaxi Jan 26, 2024
4c8ddf2
move types, fix tsconfig, scripts
hayemaxi Jan 27, 2024
e483b28
fix linting, add header to gitignore-parser.d.ts
hayemaxi Jan 29, 2024
d90ee4a
move templates/, syntaxes/ resources/ to packages/toolkit/. command …
hayemaxi Jan 29, 2024
7bccd17
enable browser webpack again, copy doc files over for extension packing.
hayemaxi Jan 29, 2024
f4b4f10
move src/browser workspace from toolkit package.json to root package.…
hayemaxi Jan 29, 2024
bd6e4ed
update some CI commands to use -w packages/toolkit
hayemaxi Jan 29, 2024
aa81e7b
update .gitignore + temp update to remove generated resources
hayemaxi Jan 30, 2024
f8bdf6e
remove generated resources
hayemaxi Jan 30, 2024
b1c2346
update .gitignore and .prettierignore, temp move endpoints.json to or…
hayemaxi Jan 30, 2024
d0e2c38
update .prettierignore for endpoints.json, move endpoints.json under …
hayemaxi Jan 30, 2024
e3613e6
restore newline in endspoints.json
hayemaxi Jan 30, 2024
88d86c7
fix vscode debugging configurations, misc package.json updates.
hayemaxi Jan 31, 2024
2a24633
update format, lint scripts, and .ignore files
hayemaxi Jan 31, 2024
752d504
move .c8rc.json to packages/toolkit
hayemaxi Jan 31, 2024
797b44c
add testCompile root shortcut
hayemaxi Jan 31, 2024
575a3f6
update .test-coverage output path
hayemaxi Jan 31, 2024
81740b2
add generateNonCodeFiles script root shortcut
hayemaxi Jan 31, 2024
c69c256
temp: delete package.json
hayemaxi Feb 5, 2024
9164073
Merge branch 'master' of https://github.com/aws/aws-toolkit-vscode in…
hayemaxi Feb 5, 2024
ed75c6f
restore root package.json and package-lock.json after mainline merge
hayemaxi Feb 5, 2024
897087c
move createRelease script to root, update packaging ignore.
hayemaxi Feb 5, 2024
e3b0d57
script moves packaged .vsix to root
hayemaxi Feb 5, 2024
64c98e5
restore codecov.yml to original
hayemaxi Feb 5, 2024
817fe4a
update .eslintignore
hayemaxi Feb 5, 2024
00b742c
fix testRunner to output report to top-level .test-reports/
hayemaxi Feb 5, 2024
dd0024a
restore SNAPSHOT to toolkit package.json
hayemaxi Feb 5, 2024
db9f77c
Merge branch 'master' of https://github.com/aws/aws-toolkit-vscode in…
hayemaxi Feb 5, 2024
21c66e2
Add/update documentation.
hayemaxi Feb 5, 2024
8fee66b
remove merge conflict resolution anomaly: download.ts
hayemaxi Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/toolkit/src/test/globalSetup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { getTestWindow, resetTestWindow } from './shared/vscode/window'
import { mapTestErrors, normalizeError, setRunnableTimeout } from './setupUtil'
import { TelemetryDebounceInfo } from '../shared/vscode/commands2'

const testReportDir = join(__dirname, '../../../.test-reports')
const testReportDir = join(__dirname, '../../../../../.test-reports') // Root project, not subproject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future: should concepts like globalSetup.test.ts should be shared ? They solve lots of edge-cases and copy-pasting that across the subprojects adds quality risk.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes there should be a shared test setup function/library in a commons folder. Will document.

const testLogOutput = join(testReportDir, 'testLog.log')
const globalSandbox = sinon.createSandbox()
const maxTestDuration = 30_000
Expand Down