Skip to content

fix(amazonq): handle existing Flare connection when migrating SSO connections #7363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

opieter-aws
Copy link
Contributor

@opieter-aws opieter-aws commented May 22, 2025

Problem

Auth migration to LSP is not handled gracefully when a user downgrades and upgrades to auth on LSP multiple times, causing users to be logged out if they upgrade a second time

Solution

In the auth migration script, call the LSP identity server to check if a token is available. If the token is available, don't migrate the auth connection. If no token is available, migrate.

Added unit tests for the case.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@opieter-aws opieter-aws changed the title fix(amazonq): handle existing Flare connection when migrating SSO con… fix(amazonq): handle existing Flare connection when migrating SSO connections May 22, 2025
@opieter-aws opieter-aws marked this pull request as ready for review May 22, 2025 20:56
@opieter-aws opieter-aws requested review from a team as code owners May 22, 2025 20:56
@opieter-aws
Copy link
Contributor Author

/retryBuilds

@opieter-aws opieter-aws merged commit 0ddbf4a into aws:feature/flare-mega May 23, 2025
16 of 22 checks passed
@opieter-aws opieter-aws deleted the feature/auth-migration branch May 23, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants