Skip to content

Conversation

@kzr-at-amazon
Copy link
Contributor

@kzr-at-amazon kzr-at-amazon commented Nov 20, 2025

Problem

  • Project node is not loading automatically after reauthentication

Solution

  • After re-authentication, set the project, then refresh the node

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kzr-at-amazon kzr-at-amazon requested a review from a team as a code owner November 20, 2025 04:55
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@kzr-at-amazon kzr-at-amazon changed the title reload project node after re-auth fix(smus): reload project node after re-auth Nov 20, 2025
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

try {
await smusAuthProvider.reauthenticate(connection)
const projectNode = smusRootNode.getProjectSelectNode()
const project = projectNode.getProject()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you close IDE, return to a state requiring re-auth, does the project node still exist in memory? Can you test? I would think not and won't that cause a NPE or is that somehow handled? If yes, please explain how.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project node is always there. I have tested

  • root node is created in activate() link
  • Project node is created in root node constructor link

@laileni-aws
Copy link
Contributor

@kzr-at-amazon Do we need this PR? If no please close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants