-
Notifications
You must be signed in to change notification settings - Fork 744
fix(smus): reload project node after re-auth #8330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/smus
Are you sure you want to change the base?
Conversation
|
6a8fd96 to
510273e
Compare
|
510273e to
f6988e3
Compare
| try { | ||
| await smusAuthProvider.reauthenticate(connection) | ||
| const projectNode = smusRootNode.getProjectSelectNode() | ||
| const project = projectNode.getProject() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you close IDE, return to a state requiring re-auth, does the project node still exist in memory? Can you test? I would think not and won't that cause a NPE or is that somehow handled? If yes, please explain how.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@kzr-at-amazon Do we need this PR? If no please close this PR |
Problem
Solution
feature/xbranches will not be squash-merged at release time.