-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing headers for fetch #687
Conversation
Also added this bug to undici: |
Thanks for the fix and improvements for this and the undici package! The changes lgtm. We can remove Not sure why the codecov is failing suddenly on the Node16.x/Ubuntu test, I'll look into this (and also #688). It should be unrelated to your PR.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #687 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 36 36
Lines 1813 1813
=======================================
Hits 1515 1515
Misses 298 298 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
I've fixed the failing codecov in #692 and merged the fix into your branch, along with some minor fixes to the package-lock files. |
Issue #679:
Description of changes:
enableCapture
function. This provides the ability to use this without changing globals. It also provides the ability to use different Request classes, e.g. undici.Request instead of globalThis.Request. This should provide a way for anyone who wants to use undici withdispatcher
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.