Conversation
…ws#1779) Blank nodes carry the synthetic LABELS.MISSING_TYPE, which never appears in the schema. Asserts useGraphStyles still emits a node[type=...] entry for it with the default icon, matching the details-panel fallback. Runs under jsdom: happy-dom's DOMParser/DOMPurify interop drops the svg root during sanitize, so svg icon resolution can never complete there. Relates to aws#1779; ports the coverage asked for on aws#1781 to the current icon-registry pipeline.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the regression coverage requested on #1781 (and #1779) to the current icon-registry pipeline: asserts
useGraphStylesemits anode[type="«No Type»"]entry with the default icon for vertices without a schema type — the same fallback the details panel uses.While scoping I verified the described root cause no longer matches the code:
useAllVertexStylesalways appends aLABELS.MISSING_TYPEentry anduseBackgroundImageMapresolves the default icon through the registry (probed green). So this PR is test-only; no behavior change. If maintainers would rather close #1779 as fixed-by-refactor, this test still locks the behavior in.Type of change
Validation
useGraphStyles.test.tsxfile green (16/16).oxlint+oxfmt --checkclean on the touched file.<svg>root during sanitize, so svg icon resolution can never complete there; jsdom matches browser behavior (same env asuseBackgroundImageMap.test.ts).