Sample each edge type with its own limit, 10 types per request - #2279
Merged
Merged
Conversation
This was referenced Sep 25, 2026
kmcginnes
added this pull request to stack #2283
September 25, 2026 22:25
kmcginnes
added a commit
that referenced
this pull request
Sep 25, 2026
## Description - `mapWithConcurrency` rejected on the first failure, but its other lanes kept looping and sending requests nobody was waiting for. The first rejection now stops the pool from starting new work. Callbacks already running aren't cancelled. - This also affects openCypher and SPARQL schema and edge connection fetches, which used to drain the whole queue after a failure. - Later in the stack, edge connection discovery relies on this, so abandoning an attempt actually stops it. ## Validation - New test: after one callback rejects, no further callbacks start. - `pnpm checks` and `pnpm test` clean on this layer. ## Related Issues - Part of #2141 (split out of #2244) - Layer 1 of 6. Stack, bottom first: #2281 → #2277 → #2278 → #2279 → #2280 → #2282 ### Check List - [x] I confirm that my contribution is made under the terms of the Apache 2.0 license. - [x] I have verified `pnpm checks` passes with no errors. - [x] I have verified `pnpm test` passes with no failures. - [x] I have covered new added functionality with unit tests if necessary. - [x] I have updated documentation if necessary.
kmcginnes
added a commit
that referenced
this pull request
Sep 25, 2026
## Description - `mapWithConcurrency` rejected on the first failure, but its other lanes kept looping and sending requests nobody was waiting for. The first rejection now stops the pool from starting new work. Callbacks already running aren't cancelled. - This also affects openCypher and SPARQL schema and edge connection fetches, which used to drain the whole queue after a failure. - Later in the stack, edge connection discovery relies on this, so abandoning an attempt actually stops it. ## Validation - New test: after one callback rejects, no further callbacks start. - `pnpm checks` and `pnpm test` clean on this layer. ## Related Issues - Part of #2141 (split out of #2244) - Layer 1 of 6. Stack, bottom first: #2281 → #2277 → #2278 → #2279 → #2280 → #2282 ### Check List - [x] I confirm that my contribution is made under the terms of the Apache 2.0 license. - [x] I have verified `pnpm checks` passes with no errors. - [x] I have verified `pnpm test` passes with no failures. - [x] I have covered new added functionality with unit tests if necessary. - [x] I have updated documentation if necessary.
kmcginnes
force-pushed
the
edge-stack/4-sample-edge-connections-per-type
branch
from
September 25, 2026 22:46
8fd035a to
f63dd71
Compare
kmcginnes
force-pushed
the
edge-stack/4-sample-edge-connections-per-type
branch
from
September 25, 2026 23:16
f63dd71 to
e238290
Compare
kmcginnes
force-pushed
the
edge-stack/4-sample-edge-connections-per-type
branch
2 times, most recently
from
September 25, 2026 23:40
24e4e84 to
55a3574
Compare
kmcginnes
marked this pull request as ready for review
September 25, 2026 23:42
kmcginnes
force-pushed
the
edge-stack/4-sample-edge-connections-per-type
branch
from
September 26, 2026 17:48
55a3574 to
f569cbb
Compare
kmcginnes
force-pushed
the
edge-stack/4-sample-edge-connections-per-type
branch
from
September 26, 2026 21:57
f569cbb to
d01f960
Compare
kmcginnes
removed this pull request from stack #2283
September 26, 2026 23:14
kmcginnes
force-pushed
the
edge-stack/4-sample-edge-connections-per-type
branch
from
September 26, 2026 23:15
d01f960 to
b3fe4ce
Compare
kmcginnes
changed the base branch from
edge-stack/3-advanced-connection-options
to
edge-stack/2-schema-view-without-edge-connections
September 26, 2026 23:15
kmcginnes
added this pull request to stack #2289
September 26, 2026 23:15
kmcginnes
added a commit
that referenced
this pull request
Sep 26, 2026
## Description - Fetch Timeout and Neighbor Expansion Limit move into a collapsible "Advanced options" section of the connection dialog, so the common fields aren't buried. - The section opens by itself when the connection already overrides one of them, so an existing override is never hidden. - The trigger is a real button, so it works from the keyboard and announces whether it's expanded. - The Fetch Timeout error message and the troubleshooting guide now point at the connection's advanced options. ## Validation - Tests that the section starts collapsed, expands on click, and opens itself for a connection with a Fetch Timeout override. - `pnpm checks` and `pnpm test` clean on this layer. ## Screenshots A new connection starts with the advanced options collapsed. <img width="720" alt="New connection dialog with Advanced options collapsed" src="https://github.com/user-attachments/assets/134122d6-9eaf-40ef-ba2d-09ae22516c85" /> Expanding them shows Fetch Timeout and Neighbor Expansion Limit. <img width="720" alt="Advanced options expanded, showing Enable Fetch Timeout and Override Default Neighbor Expansion Limit" src="https://github.com/user-attachments/assets/77f7d6d5-3dce-4c6c-b33e-55eecc8b71df" /> Editing a connection that already sets a Fetch Timeout opens the section by itself. <img width="720" alt="Editing a connection with a 30000 ms fetch timeout, with Advanced options already open" src="https://github.com/user-attachments/assets/dd71d9cd-ca86-45c7-8ffd-ff0af44b387d" /> ## Related Issues - Part of #2141 (split out of #2244) - Layer 1 of 5. Stack, bottom first: #2278 → #2277 → #2279 → #2280 → #2282 ### Check List - [x] I confirm that my contribution is made under the terms of the Apache 2.0 license. - [x] I have verified `pnpm checks` passes with no errors. - [x] I have verified `pnpm test` passes with no failures. - [x] I have covered new added functionality with unit tests if necessary. - [x] I have updated documentation if necessary.
kmcginnes
removed this pull request from stack #2289
September 26, 2026 23:34
kmcginnes
changed the base branch from
edge-stack/2-schema-view-without-edge-connections
to
main
September 26, 2026 23:34
kmcginnes
force-pushed
the
edge-stack/4-sample-edge-connections-per-type
branch
from
September 26, 2026 23:34
b3fe4ce to
5dbbc40
Compare
kmcginnes
added this pull request to stack #2290
September 26, 2026 23:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the fix for #2141 on its own, with the existing batching and no new setting or strategy.
union()branch, so the 10,000-edge limit applies before anything is read. One limit afterhasLabel(A, B, ...)would be shared, and a dominant type would fill it and leave the rest empty.V().limit(1)becauseinject()isn't native on Neptune, and mid-traversalV()becauseE()there needs TinkerPop 3.7.DEFAULT_BATCH_REQUEST_SIZEare unchanged.::, so a multi-label vertex keeps every label on Neptune 1.4 (one composite) and 1.3.5 (one entry per label). Before, 1.3.5 silently kept only the first.createEdgeConnectionId, so a label containing the old-separator can't collide.Validation
pnpm checksandpnpm testclean on this layer.Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.