feat: Add full warnings list, dont ouput warning if disabled #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrgrain is there someone that can review and move this pr along? |
mrgrain
requested changes
Apr 28, 2025
There was a problem hiding this comment.
Thanks for the PR @Dzuelu ! Please start by describing the problem you are trying to resolve or the feature you are trying to add. Ideally this would be in a separate issue.
I think I have a vague idea of what it is you want to do, but it will help if you describe it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added full warning list w/ test for future warnings. Checked warning list before pushing diagnostic item.
Note:
jsii-directive/struct-on-non-interfacehad nothing using it from what I could tell.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.