Add changeSelectedTab #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogusata
reviewed
Feb 21, 2024
There was a problem hiding this comment.
This change should not be implemented right away. This was a UX decision we did to avoid multiple platform use multiple tabs and tries to get focus several times can cause misbehaving. You should not change tabs on behalf of user.
As VSCode and also IntelliJ blocks target focusing to extensions and mynah-ui can be used from multiple data providers at the same time it is unsafe to give the ability to change the tab.
Please describe the reason why it is necessary, UX flow decisions and the use case please.
Expected steps are:
- Create a feature request, describe the reason
- Wait till the final decision happen on the discussion
- Depending on the decision, you can contribute or wait for the implementation.
|
And please do not forget adding a detailed description to the PR which tells:
|
|
After discussing it, the feature was included in 0844cc1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.