feat(s2n-quic-core): add task cooldown module #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/hybrid-poll
branch
3 times, most recently
from
5ee8ee9
to
e49116c
Compare
camshaft
force-pushed
the
camshaft/hybrid-poll
branch
2 times, most recently
from
cbddba9
to
0b43134
Compare
camshaft
force-pushed
the
camshaft/hybrid-poll
branch
2 times, most recently
from
72d9a60
to
fe15338
Compare
camshaft
force-pushed
the
camshaft/hybrid-poll
branch
from
fe15338
to
d9590bf
Compare
| use super::*; | ||
|
|
||
| #[test] | ||
| fn cooldown_test() { |
There was a problem hiding this comment.
can you add a test that uses Cooldown::new(0), since that's how customers not using the unstable feature would end up using it?
WesleyRosenblum
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This changes adds an experimental hybrid polling mode that allows for busy polling by self-waking a task for a configurable number of iterations rather than registering a waker and waiting for the other side to call
.wake(). This can improve latency in high-throughput scenarios by avoiding the relatively expensive operation of waking up another thread. After the iteration limit is reached, the task registers the waker as normal. This avoids the need to do busy polling the whole time where we don't have a burst of computation to perform.Call-outs:
This is experimental at the moment so we can kick the tires on it and show it working in actual environments. If the improvement doesn't translate there, it'll be removed instead.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.